[webkit-reviews] review granted: [Bug 208392] Clean up code with how we choose Gigacage sizes and whether or not to use Wasm fast memory : [Attachment 392018] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 208392: Clean up code with how we choose Gigacage sizes and whether or not
to use Wasm fast memory
https://bugs.webkit.org/show_bug.cgi?id=208392

Attachment 392018: patch

https://bugs.webkit.org/attachment.cgi?id=392018&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 392018
  --> https://bugs.webkit.org/attachment.cgi?id=392018
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392018&action=review

r=me

> Source/JavaScriptCore/runtime/OptionsList.h:462
> +    v(Bool, useWebAssemblyFastMemory,
WTF_OS_CONSTANT_EFFECTIVE_ADDRESS_WIDTH >= 48, Normal, "If true, we will try to
use a 32-bit address space with a signal handler to bounds check wasm memory.")
\

Use `OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH)` instead.