[webkit-reviews] review granted: [Bug 208382] Garbage collection prevents FontFace.loaded promise from getting resolved : [Attachment 392014] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 208382: Garbage collection prevents FontFace.loaded promise from getting
resolved
https://bugs.webkit.org/show_bug.cgi?id=208382

Attachment 392014: Patch

https://bugs.webkit.org/attachment.cgi?id=392014&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 392014
  --> https://bugs.webkit.org/attachment.cgi?id=392014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392014&action=review

> Source/WebCore/css/FontFace.cpp:490
> +    return !isContextStopped() && m_isScriptPotentiallyInterestedInLoad &&
!m_loadedPromise->isFulfilled();

Should we clear m_isScriptPotentiallyInterestedInLoad when we're fulfilled the
promise?