[webkit-reviews] review granted: [Bug 208389] Clear FontDatabase when low-memory-warning happens : [Attachment 392012] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 208389: Clear FontDatabase when low-memory-warning happens
https://bugs.webkit.org/show_bug.cgi?id=208389

Attachment 392012: Patch

https://bugs.webkit.org/attachment.cgi?id=392012&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 392012
  --> https://bugs.webkit.org/attachment.cgi?id=392012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392012&action=review

r=me with change.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1385
> +#if HAVE(DISALLOWABLE_USER_INSTALLED_FONTS)

You can replace all this with simply:
    FontDatabase::singletonAllowingUserInstalledFonts().clear();
    FontDatabase::singletonDisallowingUserInstalledFonts().clear();

without ifdefs. FontDatabase::singletonAllowingUserInstalledFonts() &
FontDatabase::singletonDisallowingUserInstalledFonts() resolve to
FontDatabase::singleton() when !HAVE(DISALLOWABLE_USER_INSTALLED_FONTS)