[webkit-reviews] review granted: [Bug 208377] Fix issue in cmake build for checking ccache : [Attachment 391988] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 208377: Fix issue in cmake build for checking ccache
https://bugs.webkit.org/show_bug.cgi?id=208377

Attachment 391988: Patch

https://bugs.webkit.org/attachment.cgi?id=391988&action=review




--- Comment #6 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 391988
  --> https://bugs.webkit.org/attachment.cgi?id=391988
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391988&action=review

>>>> Source/cmake/WebKitCCache.cmake:17
>>>> +		  if (${WHICH_RETCODE} EQUAL 0 AND ${READLINK_RETCODE} EQUAL 0
AND "${REAL_CXX_PATH}" STREQUAL "${REAL_CCACHE_PATH}")
>>> 
>>> This codeblock should not execute on Mac.
>>> Its inside a if (!PORT STREQUAL "Mac")
>> 
>> If you build JSCOnly you'll hit it.
> 
> Regardless, you'll have the same problem if either of the command fails on
any other platform for some reason.

I see