[webkit-reviews] review granted: [Bug 208374] [GTK][WPE] Stop using mediaControlsBase.js : [Attachment 391976] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted  review:
Bug 208374: [GTK][WPE] Stop using mediaControlsBase.js
https://bugs.webkit.org/show_bug.cgi?id=208374

Attachment 391976: Patch

https://bugs.webkit.org/attachment.cgi?id=391976&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 391976
  --> https://bugs.webkit.org/attachment.cgi?id=391976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391976&action=review

Nit: things are ok as they are now but if you feel like giving it another shot,
I would try to use let and const instead of var. Obviously let for things that
are going to change and const for those that are not. Your call.

> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:336
> +	   this.controls.panel.classList.add(this.ClassNames.show);
> +	   this.controls.panel.classList.remove(this.ClassNames.hidden);

Nit: I think it makes more sense to switch these lines to remove the hidden
first and then add the show.