[webkit-reviews] review granted: [Bug 208365] UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window : [Attachment 391954] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 208365: UIProcess crash after using _prepareForMoveToWindow, then
deallocating the WKWebView before moving to the window
https://bugs.webkit.org/show_bug.cgi?id=208365

Attachment 391954: Patch

https://bugs.webkit.org/attachment.cgi?id=391954&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 391954
  --> https://bugs.webkit.org/attachment.cgi?id=391954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391954&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:204
> +    __weak NSWindow *_observingWindow;

Is this ARC code?  Does __weak do anything here?
Could you use WeakObjCPtr?