[webkit-reviews] review denied: [Bug 208349] Introduce JSRemoteInspectorServerStart API for socket-based RWI. : [Attachment 391937] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 208349: Introduce JSRemoteInspectorServerStart API for socket-based RWI.
https://bugs.webkit.org/show_bug.cgi?id=208349

Attachment 391937: Patch

https://bugs.webkit.org/attachment.cgi?id=391937&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 391937
  --> https://bugs.webkit.org/attachment.cgi?id=391937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391937&action=review

> Source/JavaScriptCore/API/JSRemoteInspector.h:55
> +#if USE(INSPECTOR_SOCKET_SERVER)
> +JS_EXPORT bool JSRemoteInspectorServerStart(uint16_t port)
JSC_API_AVAILABLE(macos(JSC_MAC_TBA), ios(JSC_IOS_TBA));
> +#endif
> +

I'm pretty sure having a USE in the API headers is a no go. These are all C
headers. I'm going to guess there might need to be a JSRemoteInspectorSocket.h.