[webkit-reviews] review granted: [Bug 208334] Change HitTestRequestType to an OptionSet : [Attachment 391923] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 208334: Change HitTestRequestType to an OptionSet
https://bugs.webkit.org/show_bug.cgi?id=208334

Attachment 391923: Patch

https://bugs.webkit.org/attachment.cgi?id=391923&action=review




--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 391923
  --> https://bugs.webkit.org/attachment.cgi?id=391923
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391923&action=review

> Source/WebCore/rendering/HitTestRequest.h:55
> +	   ASSERT(!requestType.contains(IncludeAllElementsUnderPoint) ||
requestType.contains(CollectMultipleElements));

Nit - IMO, this assertion could be made clearer using ASSERT_IMPLIES.