[webkit-reviews] review granted: [Bug 208256] [WinCairo] Fix RemoteInspector reconnect issue : [Attachment 391785] PATCH
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 27 13:35:29 PST 2020
Devin Rousso <drousso at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 208256: [WinCairo] Fix RemoteInspector reconnect issue
https://bugs.webkit.org/show_bug.cgi?id=208256
Attachment 391785: PATCH
https://bugs.webkit.org/attachment.cgi?id=391785&action=review
--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 391785
--> https://bugs.webkit.org/attachment.cgi?id=391785
PATCH
View in context: https://bugs.webkit.org/attachment.cgi?id=391785&action=review
r=me
> Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.cpp:92
> + if (m_target) {
Style: this could be an early return instead, so everything is indented one
level less
> Source/WTF/wtf/RunLoop.h:235
> + WTF::Function<void()> m_wakeUpCallback;
I think you can drop the `WTF::`
More information about the webkit-reviews
mailing list