[webkit-reviews] review granted: [Bug 208192] [Curl] Add TLS debugging feature to log encryption keys : [Attachment 391853] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 208192: [Curl] Add TLS debugging feature to log encryption keys
https://bugs.webkit.org/show_bug.cgi?id=208192

Attachment 391853: Patch

https://bugs.webkit.org/attachment.cgi?id=391853&action=review




--- Comment #25 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 391853
  --> https://bugs.webkit.org/attachment.cgi?id=391853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391853&action=review

LGTM

> Source/cmake/OptionsWinCairo.cmake:58
> +WEBKIT_OPTION_END()

WEBKIT_OPTION_END is already called in OptionsWin.cmake for WinCairo.
It seems that WEBKIT_OPTION_END shouldn't be called twice because
FEATURE_DEFINES will get duplicated entries.
I think it should be moved into OptionsWin.cmake.

if (WTF_PLATFORM_WIN_CAIRO)
    WEBKIT_OPTION_DEFINE(ENABLE_TLS_DEBUG "Enable TLS key log support" PRIVATE
ON)
endif ()