[webkit-reviews] review denied: [Bug 208250] [iOS] The GPU process never runs as a foreground process : [Attachment 391892] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 208250: [iOS] The GPU process never runs as a foreground process
https://bugs.webkit.org/show_bug.cgi?id=208250

Attachment 391892: Patch

https://bugs.webkit.org/attachment.cgi?id=391892&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 391892
  --> https://bugs.webkit.org/attachment.cgi?id=391892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391892&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2045
> +	       if (auto gpuProcess = GPUProcessProxy::singletonIfCreated())

Now we take process assertions for the GPU process in 2 places, here and in
existing GPUProcessProxy::updateProcessAssertion() code. This seems wrong.

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:127
> +    , m_throttler(*this, true)

Seems like this should be using processPool.shouldTakeUIBackgroundAssertion()

> Source/WebKit/UIProcess/ios/WKContentView.mm:263
> +- (void)_removeVisibilityPropagationViewForGPUProcess

Who is calling this?