[webkit-reviews] review denied: [Bug 208330] [Win] Fix AppleWin build : [Attachment 391893] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 208330: [Win] Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=208330

Attachment 391893: Patch

https://bugs.webkit.org/attachment.cgi?id=391893&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 391893
  --> https://bugs.webkit.org/attachment.cgi?id=391893
Patch

This is wrong. You should be setting this to where the headers actually are.

I'm guessing you should move the setting of these values into the target files.
So like

set(WTF_FRAMEWORK_HEADERS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF")

Also https://bugs.webkit.org/show_bug.cgi?id=205085 still needs to land