[webkit-reviews] review granted: [Bug 208264] REGRESSION: (257072) [ Mac wk2 Release ] fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html is flaky failing. : [Attachment 391891] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 27 11:03:50 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 208264: REGRESSION: (257072) [ Mac wk2 Release ]
fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html is flaky
failing.
https://bugs.webkit.org/show_bug.cgi?id=208264

Attachment 391891: patch

https://bugs.webkit.org/attachment.cgi?id=391891&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391891
  --> https://bugs.webkit.org/attachment.cgi?id=391891
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391891&action=review

>
LayoutTests/fast/harness/uiscriptcontroller/concurrent-ui-side-scripts.html:71
> +	       document.getElementById('results').textContent += 'Script 1:\n'
+ script1Result + 'Script 2:\n' + script2Result;

Another option is to have two "results" divs, one per async script. Then
ordering will be document order.


More information about the webkit-reviews mailing list