[webkit-reviews] review granted: [Bug 208286] TextManipulationController should not generate a new item for content in manipulated paragraphs : [Attachment 391839] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 208286: TextManipulationController should not generate a new item for
content in manipulated paragraphs
https://bugs.webkit.org/show_bug.cgi?id=208286

Attachment 391839: Patch

https://bugs.webkit.org/attachment.cgi?id=391839&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 391839
  --> https://bugs.webkit.org/attachment.cgi?id=391839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391839&action=review

> Source/WebCore/ChangeLog:10
> +	   Added an early exist to observeParagraphs when the observed content
has an element that has already been manipulated

"early exist” => "early exit"

> Source/WebCore/ChangeLog:16
> +	   forever so that we can track any element that has already been
manipulated. Als renamed m_mutatedElements

“Als” => “Also"

> Source/WebCore/editing/TextManipulationController.cpp:117
> +    if (!m_manipulatedElements.capacity())

Can we just check isEmpty() here?