[webkit-reviews] review granted: [Bug 208298] Load async scripts with low priority : [Attachment 391854] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 27 07:02:38 PST 2020


Anders Carlsson <andersca at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 208298: Load async scripts with low priority
https://bugs.webkit.org/show_bug.cgi?id=208298

Attachment 391854: patch

https://bugs.webkit.org/attachment.cgi?id=391854&action=review




--- Comment #2 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 391854
  --> https://bugs.webkit.org/attachment.cgi?id=391854
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391854&action=review

> Source/WebCore/dom/LoadableClassicScript.cpp:134
> +	   return { };

I'd return std::nullopt here, but that's just me.


More information about the webkit-reviews mailing list