[webkit-reviews] review granted: [Bug 208294] REGRESSION(r257299): [GTK] Make focus ring of image area consistent with the theme : [Attachment 391846] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 27 05:30:19 PST 2020
Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 208294: REGRESSION(r257299): [GTK] Make focus ring of image area consistent
with the theme
https://bugs.webkit.org/show_bug.cgi?id=208294
Attachment 391846: Patch
https://bugs.webkit.org/attachment.cgi?id=391846&action=review
--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 391846
--> https://bugs.webkit.org/attachment.cgi?id=391846
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=391846&action=review
Patch LGTM but there is a typo that is breaking the other ports (see below).
That needs to be fixed before landing, hence the cq-.
> Source/WebCore/html/HTMLAreaElement.cpp:140
> + return TWF::nullopt;
s/TWF/WTF
More information about the webkit-reviews
mailing list