[webkit-reviews] review granted: [Bug 206894] [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser : [Attachment 391823] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 27 00:50:46 PST 2020
Adrian Perez <aperez at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 206894: [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=206894
Attachment 391823: Patch
https://bugs.webkit.org/attachment.cgi?id=391823&action=review
--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 391823
--> https://bugs.webkit.org/attachment.cgi?id=391823
Patch
The WPE/GTK parts of the patch look good. The Windows bits also look
fine to me but I can't be 100% sure so you might want to have some
other pair of eyes glance at it before landing.
More information about the webkit-reviews
mailing list