[webkit-reviews] review granted: [Bug 206456] Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier : [Attachment 391820] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206456: Remove unused
WebsiteDataStore::setSourceApplicationBundleIdentifier
https://bugs.webkit.org/show_bug.cgi?id=206456

Attachment 391820: Patch

https://bugs.webkit.org/attachment.cgi?id=391820&action=review




--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 391820
  --> https://bugs.webkit.org/attachment.cgi?id=391820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391820&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:346
> -    return _websiteDataStore->sourceApplicationBundleIdentifier();
> +    return nil;

Why leave this here at all?

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:351
>  - (void)_setSourceApplicationBundleIdentifier:(NSString *)identifier
>  {
> -    if
(!_websiteDataStore->setSourceApplicationBundleIdentifier(identifier))
> -	   [NSException raise:NSGenericException
format:@"_setSourceApplicationBundleIdentifier cannot be called after
networking has begun"];
>  }

Ditto