[webkit-reviews] review granted: [Bug 208179] Create AudioDestination in the GPU process : [Attachment 391728] Windows build fix attempt 3

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 208179: Create AudioDestination in the GPU process
https://bugs.webkit.org/show_bug.cgi?id=208179

Attachment 391728: Windows build fix attempt 3

https://bugs.webkit.org/attachment.cgi?id=391728&action=review




--- Comment #12 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 391728
  --> https://bugs.webkit.org/attachment.cgi?id=391728
Windows build fix attempt 3

r=me. I'm really happy with the MediaStrategy changes and the addition of a
receiverMap to the GPUProcessConnection class. I wonder whether the
PlatformStrategies should all have default implementations inside WebCore, so
subclasses can just return PlatformStrategy::create...() rather than have
WebKit and WebKitLegacy both have to hard code the default behavior, but since
that's a decision that would affect all the other strategies and isn't specific
to media, we could table that discussion for a future patch.