[webkit-reviews] review granted: [Bug 208260] TestWebKitAPI and WebKitTestRunner should have bundle identifiers : [Attachment 391779] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 208260: TestWebKitAPI and WebKitTestRunner should have bundle identifiers
https://bugs.webkit.org/show_bug.cgi?id=208260

Attachment 391779: Patch

https://bugs.webkit.org/attachment.cgi?id=391779&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 391779
  --> https://bugs.webkit.org/attachment.cgi?id=391779
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391779&action=review

> Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:27
> +PRODUCT_BUNDLE_IDENTIFIER = com.apple.TestWebKitAPI;

I wonder if these should be com.apple.WebKit.* like the subprocesses are

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:5333
> +				CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
> +				INFOPLIST_FILE = "$(SRCROOT)/Info.plist";

You should move these two lines to the xcconfig, not here.

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:5342
> +				CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
> +				INFOPLIST_FILE = "$(SRCROOT)/Info.plist";

Ditto

> Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:1291
> +				CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
> +				INFOPLIST_FILE = "$(SRCROOT)/Info.plist";

Ditto etc etc etc