[webkit-reviews] review granted: [Bug 208146] [iOS] Issue mach sandbox extensions to the WebContent process for a set of specific services : [Attachment 391587] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 208146: [iOS] Issue mach sandbox extensions to the WebContent process for a
set of specific services
https://bugs.webkit.org/show_bug.cgi?id=208146

Attachment 391587: Patch

https://bugs.webkit.org/attachment.cgi?id=391587&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 391587
  --> https://bugs.webkit.org/attachment.cgi?id=391587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391587&action=review

Very nice! r=me.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:264
> +	  
SandboxExtension::consumePermanently(parameters.dynamicMachExtensionHandles[i])
;

Someday we should make a proper iterator interface for
SandboxExtension::HandleArray so we can use modern looping.