[webkit-reviews] review granted: [Bug 207916] Add logging to help diagnose redirect issue : [Attachment 391703] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Keith Rollin <krollin at apple.com>'s
request for review:
Bug 207916: Add logging to help diagnose redirect issue
https://bugs.webkit.org/show_bug.cgi?id=207916

Attachment 391703: Patch

https://bugs.webkit.org/attachment.cgi?id=391703&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 391703
  --> https://bugs.webkit.org/attachment.cgi?id=391703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391703&action=review

r=me with fixes

> Source/WebCore/ChangeLog:15
> +	   Reviewed by NOBODY (OOPS!).

This comes *before* the description.

> Source/WebKit/ChangeLog:15
> +	   Reviewed by NOBODY (OOPS!).

Ditto.

> Source/WebCore/loader/PolicyChecker.cpp:136
> +	   RELEASE_LOG_IF_ALLOWED("checkNavigationPolicy: continuing because
empty URL");

or because it is the same as last request.

> Source/WebCore/loader/PolicyChecker.cpp:155
> +	       RELEASE_LOG_IF_ALLOWED("checkNavigationPolicy: ignoring because
the content filter told us not to");

This should say that we are not continuing *with substitute data*, to indicate
clearly that we are in the substitute data code path.

> Source/WebCore/loader/PolicyChecker.cpp:188
> +	   RELEASE_LOG_IF_ALLOWED("checkNavigationPolicy: ignoring because
mumble-content-filter-unblock-handler-mumble");

because ContentFilterUnblockHandler can handle the request

> Source/WebCore/loader/ResourceLoader.cpp:397
> +	       RELEASE_LOG_IF_ALLOWED("willSendRequestInternal: resource load
reached terminal state");

... after calling assignIdentifierToInitialRequest()

> Source/WebCore/loader/SubresourceLoader.cpp:192
> +	   RELEASE_LOG_IF_ALLOWED("willSendRequestInternal: resource load
canceled because request is invalid");

*new* request

> Source/WebCore/loader/SubresourceLoader.cpp:206
> +		   RELEASE_LOG_IF_ALLOWED("willSendRequestInternal: resource
load canceled because request is NULL (1)");

*new* request is null

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:817
> +	   WEBFRAMELOADERCLIENT_RELEASE_LOG(Network,
"dispatchDecidePolicyForResponse: continuing because the url string is empty");

s/empty/null