[webkit-reviews] review granted: [Bug 200626] [GL][GStreamer] Instantiate GstGLContext when the shared GLContext is created : [Attachment 391657] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 200626: [GL][GStreamer] Instantiate GstGLContext when the shared GLContext
is created
https://bugs.webkit.org/show_bug.cgi?id=200626

Attachment 391657: Patch

https://bugs.webkit.org/attachment.cgi?id=391657&action=review




--- Comment #28 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 391657
  --> https://bugs.webkit.org/attachment.cgi?id=391657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391657&action=review

> Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:134
> +    if (!const_cast<PlatformDisplay*>(this)->tryEnsureGstGLContext())

I had never seen this, I think I prefer to make tryEnsureGstGLContext() const
and mark m_gstGLContext and m_gstGLDisplay as mutable, instead of a const cast
of this. Unless this is better for whatever reason...