[webkit-reviews] review granted: [Bug 208163] Web Inspector: AXI: buttons should be focusable when navigating by pressing Tab : [Attachment 391596] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 208163: Web Inspector: AXI: buttons should be focusable when navigating by
pressing Tab
https://bugs.webkit.org/show_bug.cgi?id=208163

Attachment 391596: Patch

https://bugs.webkit.org/attachment.cgi?id=391596&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 391596
  --> https://bugs.webkit.org/attachment.cgi?id=391596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391596&action=review

r=me

> Source/WebInspectorUI/ChangeLog:13
> +	   you were â the console prompt. This behavior matches MacOS.

nit: macOS

> Source/WebInspectorUI/ChangeLog:17
> +	   triggers "click" event.

Interesting!

> Source/WebInspectorUI/ChangeLog:25
> +	   Reset the default styles.

Why?

> Source/WebInspectorUI/ChangeLog:30
> +	   Before this patch, focused button looked the same as activated
buttons. For example, the focused (non-active) bullseye icon looked exactly the
same as unfocused active bullseye icon, which was misleading.

Please line-break.

> Source/WebInspectorUI/UserInterface/Views/ActivateButtonNavigationItem.js:74
> +	   this.tooltip = flag ? this._activatedToolTip : this._defaultToolTip;

In the interest of preventing programming errors, can we coerce `flag` to a
bool at the top of the function? i.e., !!flag. This wasn't as important before
but now the code sets ariaPressed to the value of flag directly.

> Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js:159
> +	   // Clicking on a button should NOT focus on it.

I think you should leave it at this one line comment. The full justification in
the changelog would be easily accessible.

> Source/WebInspectorUI/UserInterface/Views/NavigationBar.js:297
> +		   // Generally, clicking on a button should not move focus.

"If clicking on a tab, stop the event from being handled by the button element.
Instead, pass focus to the selected tab. Otherwise, let the button become
activated normally."

> Source/WebInspectorUI/UserInterface/Views/NavigationBar.js:406
> +	   this.selectedNavigationItem?.element.focus();

Wat (okay, I looked it up)