[webkit-reviews] review granted: [Bug 208214] TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes : [Attachment 391676] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 208214:
TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should
wait until copy operation completes
https://bugs.webkit.org/show_bug.cgi?id=208214

Attachment 391676: Patch

https://bugs.webkit.org/attachment.cgi?id=391676&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 391676
  --> https://bugs.webkit.org/attachment.cgi?id=391676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391676&action=review

Good catch!

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:-316
> -    [source _executeEditCommand:@"copy" argument:nil completion:nil];

Nit - it would probably be simpler to just call
-_synchronouslyExecuteEditCommand:argument:.