[webkit-reviews] review granted: [Bug 208196] [JSC][MIPS] Adding support to Checkpoints : [Attachment 391653] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 208196: [JSC][MIPS] Adding support to Checkpoints
https://bugs.webkit.org/show_bug.cgi?id=208196

Attachment 391653: Patch

https://bugs.webkit.org/attachment.cgi?id=391653&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 391653
  --> https://bugs.webkit.org/attachment.cgi?id=391653
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391653&action=review

r=me

> Source/JavaScriptCore/offlineasm/mips.rb:688
> +	       if node.name =~ /^.*_return_location(?:_(?:wide16|wide32))?$/ or
node.name.start_with?("_checkpoint_osr_exit_from_inlined_call_trampoline")

This sounds like, we should rename
_checkpoint_osr_exit_from_inlined_call_trampoline to
_checkpoint_osr_exit_from_inlined_call_trampoline_return_location, because it
is return-location.
Can you file a FIXME here?