[webkit-reviews] review denied: [Bug 207916] Add logging to help diagnose redirect issue : [Attachment 391100] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Keith Rollin
<krollin at apple.com>'s request for review:
Bug 207916: Add logging to help diagnose redirect issue
https://bugs.webkit.org/show_bug.cgi?id=207916

Attachment 391100: Patch

https://bugs.webkit.org/attachment.cgi?id=391100&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391100
  --> https://bugs.webkit.org/attachment.cgi?id=391100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391100&action=review

> Source/WebCore/loader/PolicyChecker.cpp:56
> +#define RELEASE_LOG_ALWAYS(fmt, ...) RELEASE_LOG(Loading, "%p -
PolicyChecker::" fmt, this, ##__VA_ARGS__)

Don't we normally use RELEASE_LOG_IF_ALLOWED?

> Source/WebCore/loader/PolicyChecker.cpp:133
> +	   RELEASE_LOG_ALWAYS("checkNavigationPolicy: continuing because empty
URL");

These all need to log some context (pageID, processIdentifier or something).