[webkit-reviews] review requested: [Bug 208186] [OpenSSL] Implement WebCrypto APIs for AES-CTR and AES-KW : [Attachment 391641] patch

[bugzilla-daemon at webkit.org]

Tomoki Imai <tomoki.imai at sony.com> has asked  for review:
Bug 208186: [OpenSSL] Implement WebCrypto APIs for AES-CTR and AES-KW
https://bugs.webkit.org/show_bug.cgi?id=208186

Attachment 391641: patch

https://bugs.webkit.org/attachment.cgi?id=391641&action=review




--- Comment #2 from Tomoki Imai <tomoki.imai at sony.com> ---
Created attachment 391641

  --> https://bugs.webkit.org/attachment.cgi?id=391641&action=review

patch

I noticed the previous patch attachment 391636 outputs the warning.
Source\WebCore\crypto\openssl\CryptoAlgorithmAES_CTROpenSSL.cpp(73,76): warning
C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit
shift intended?)

For 64bit machine, counterLength is 63 in the worst case, so I think 1 <<
(size_t)63 causes overflow. 
I fixed this warning by casting 1 to size_t.