[webkit-reviews] review granted: [Bug 208114] Refactor TextTrackCue to use more traditional design patterns : [Attachment 391624] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 208114: Refactor TextTrackCue to use more traditional design patterns
https://bugs.webkit.org/show_bug.cgi?id=208114

Attachment 391624: Patch

https://bugs.webkit.org/attachment.cgi?id=391624&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 391624
  --> https://bugs.webkit.org/attachment.cgi?id=391624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391624&action=review

r=me, assuming this passes EWS.

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:159
> +    return adoptRef(*new TextTrackCueGeneric(downcast<Document>(context),
start, end, content));

How do we know this is a Document?

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:236
> +	       std::pair<double, double> thisPosition =
getPositionCoordinates();
> +	       std::pair<double, double> thatPosition =
downcast<TextTrackCueGeneric>(*that).getPositionCoordinates();

This looks like a good place for auto, FloatPoint, or structured bindings.

> Source/WebCore/html/track/VTTCue.h:141
>      enum WritingDirection {

It would be nice to make these enum classes, but that kind of thing can explode
the patch.

> Source/WebCore/html/track/VTTCue.h:149
>      enum CueAlignment {

ditto.