[webkit-reviews] review granted: [Bug 208144] Assertion failed: currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableName) || currentSchema == createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate) : [Attachment 391557] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 208144: Assertion failed: currentSchema ==
createV1ObjectStoreInfoSchema(objectStoreInfoTableName) || currentSchema ==
createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)
https://bugs.webkit.org/show_bug.cgi?id=208144

Attachment 391557: Patch

https://bugs.webkit.org/attachment.cgi?id=391557&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 391557
  --> https://bugs.webkit.org/attachment.cgi?id=391557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391557&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:692
> -    RELEASE_ASSERT(currentSchema ==
createV1ObjectStoreInfoSchema(objectStoreInfoTableName) || currentSchema ==
createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate));
> +    if (currentSchema !=
createV1ObjectStoreInfoSchema(objectStoreInfoTableName) && currentSchema !=
createV1ObjectStoreInfoSchema(objectStoreInfoTableNameAlternate)) {

Don't we also want to log objectStoreInfoTableName and
objectStoreInfoTableNameAlternate?