[webkit-reviews] review granted: [Bug 207491] Add canShare function for Web Share API v2 : [Attachment 391588] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 207491: Add canShare function for Web Share API v2
https://bugs.webkit.org/show_bug.cgi?id=207491

Attachment 391588: Patch

https://bugs.webkit.org/attachment.cgi?id=391588&action=review




--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 391588
  --> https://bugs.webkit.org/attachment.cgi?id=391588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391588&action=review

> Source/WebCore/ChangeLog:9
> +	   Added files member to share data and canShare function to
> +	   navigator.cpp.

You should add some words here (about how canShare will return false if you
have any files, etc.). Also, if it makes it easier to write lots of words, you
can put them down below in the per-file comments.

> Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:616
> +// Defaults to false
> +WK_EXPORT void WKPreferencesSetWebShareFileAPIEnabled(WKPreferencesRef, bool
flag);
> +WK_EXPORT bool WKPreferencesGetWebShareFileAPIEnabled(WKPreferencesRef);

Ditto what I said about legacy webkit: if there's no reason to add C SPI, we
shouldn't.