[webkit-reviews] review denied: [Bug 207933] [Linux] StackTrace symbols are not demangled : [Attachment 391151] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 207933: [Linux] StackTrace symbols are not demangled
https://bugs.webkit.org/show_bug.cgi?id=207933

Attachment 391151: Patch

https://bugs.webkit.org/attachment.cgi?id=391151&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 391151
  --> https://bugs.webkit.org/attachment.cgi?id=391151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391151&action=review

> Source/WTF/wtf/StackTrace.cpp:141
>	   auto demangled = demangle(stack[i]);
>	   if (demangled) {
>	       mangledName = demangled->mangledName();
>	       cxaDemangled = demangled->demangledName();
>	   }

If it works, why do we have `HAVE(BACKTRACE_SYMBOLS)` path? It looks like we
should always use DLADDR path when we have BACKTRACE_SYMBOLS too.
Can we just remove BACKTRACE_SYMBOLS code?