[webkit-reviews] review granted: [Bug 208129] [GTK] Stop using gtk foreign drawing API to style form controls : [Attachment 391525] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 24 07:58:31 PST 2020


Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 208129: [GTK] Stop using gtk foreign drawing API to style form controls
https://bugs.webkit.org/show_bug.cgi?id=208129

Attachment 391525: Patch

https://bugs.webkit.org/attachment.cgi?id=391525&action=review




--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 391525
  --> https://bugs.webkit.org/attachment.cgi?id=391525
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391525&action=review

>
Source/WebCore/platform/adwaita/ThemeAdwaita.hSource/WebCore/platform/wpe/Theme
WPE.h:-46
> -

This looks like a bogus line removal.

> Source/WebCore/platform/gtk/RenderThemeGadget.h:-39
> -class RenderThemeGadget {

It makes me *so* happy to see this hairy code go away!


More information about the webkit-reviews mailing list