[webkit-reviews] review granted: [Bug 208084] [iOS] [iPadOS] REGRESSION(r247667): Autosizing style changes don't invalidate RenderText's preferred logical widths : [Attachment 391445] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 208084: [iOS] [iPadOS] REGRESSION(r247667): Autosizing style changes don't
invalidate RenderText's preferred logical widths
https://bugs.webkit.org/show_bug.cgi?id=208084

Attachment 391445: Patch

https://bugs.webkit.org/attachment.cgi?id=391445&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 391445
  --> https://bugs.webkit.org/attachment.cgi?id=391445
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391445&action=review

This looks like a good solution

> Source/WebCore/style/StyleAdjuster.h:55
> +	   operator bool() const { return newFontSize || newLineHeight; }

Maybe "explicit operator bool" is better here? I think that’s usually what we
use when we can check something as a bool, but wouldn’t want to convert it into
a bool.