[webkit-reviews] review denied: [Bug 207816] Revise DOM iterators implementation and usage : [Attachment 391374] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 207816: Revise DOM iterators implementation and usage
https://bugs.webkit.org/show_bug.cgi?id=207816

Attachment 391374: Patch

https://bugs.webkit.org/attachment.cgi?id=391374&action=review




--- Comment #15 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 391374
  --> https://bugs.webkit.org/attachment.cgi?id=391374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391374&action=review

While this patch has lot of good I don't think we want to regress in const
correctness in WebKit. I know I'm not the only one who feels it is a valuable
tool that we should be using more, not less.

> Source/WebCore/dom/TypedElementDescendantIterator.h:65
> -    const ElementType* first() const;
> -    const ElementType* last() const;
> +    ElementType* first() const;
> +    ElementType* last() const;

Gross.