[webkit-reviews] review granted: [Bug 208046] [GStreamer][WPE] Add GstGLMemoryEGL support for the video-plane-display : [Attachment 391390] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 208046: [GStreamer][WPE] Add GstGLMemoryEGL support for the
video-plane-display
https://bugs.webkit.org/show_bug.cgi?id=208046

Attachment 391390: Patch

https://bugs.webkit.org/attachment.cgi?id=391390&action=review




--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 391390
  --> https://bugs.webkit.org/attachment.cgi?id=391390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391390&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:224
> +	   if (hasDMABuf() && (m_dmabufStride == -1)) {

Extra parentheses not necessary, but OK.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:226
> +	       m_isMapped = gst_video_frame_map(&m_videoFrame, &videoInfo,
m_buffer.get(), GST_MAP_READ);
> +	       RELEASE_ASSERT(m_isMapped);

Is this really a given? or can it fail in some obscure fashion, now or in the
future?