[webkit-reviews] review granted: [Bug 208041] [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14 : [Attachment 391376] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 208041: [GStreamer] TextCombinerGStreamer is failing to compile with
Gst1.14
https://bugs.webkit.org/show_bug.cgi?id=208041

Attachment 391376: Patch

https://bugs.webkit.org/attachment.cgi?id=391376&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 391376
  --> https://bugs.webkit.org/attachment.cgi?id=391376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391376&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110
> +	   gst_tag_list_unref(combinerPad->tags);

unref and then assign to nullptr, which is what clear is doing

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113
> +	   gst_object_unref(combinerPad->funnelPad);

ditto