[webkit-reviews] review granted: [Bug 207984] [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp : [Attachment 391335] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 207984: [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle()
check in UserAgentQuirks.cpp
https://bugs.webkit.org/show_bug.cgi?id=207984

Attachment 391335: Patch

https://bugs.webkit.org/attachment.cgi?id=391335&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 391335
  --> https://bugs.webkit.org/attachment.cgi?id=391335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391335&action=review

> Source/WebCore/ChangeLog:8
> +	   Fix the check for googleapis.com. Since it's now a public suffix, we
can no longer check the

This is ok as-is. A better commit message would reference the public suffix
change for convenience and grepping

> Source/WebCore/platform/UserAgentQuirks.cpp:40
> +    String baseDomain = topPrivatelyControlledDomain(domain);

This is ok as-is. The optimal solution would be for topPriva...() to take a
StringView because it avoids a copy.

> Source/WebCore/platform/UserAgentQuirks.cpp:56
> +    if (domain.endsWith(".googleapis.com"))

Is this case-insensitive?If not, should it be?