[webkit-reviews] review granted: [Bug 208033] [iOS] Fix media related sandbox issues in the GPU Process : [Attachment 391368] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 208033: [iOS] Fix media related sandbox issues in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=208033

Attachment 391368: Patch

https://bugs.webkit.org/attachment.cgi?id=391368&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 391368
  --> https://bugs.webkit.org/attachment.cgi?id=391368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391368&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:289
> +    if (!parameters.mediaCacheDirectory.isEmpty()) {
> +	   String parentFolder = parameters.mediaCacheDirectory;
> +	   if ((auto position = parentFolder.reverseFind("/")) != notFound)
> +	       parentFolder = parentFolder.substring(0, position);
> +	   SandboxExtension::createHandleWithoutResolvingPath(parentFolder,
SandboxExtension::Type::ReadWrite,
parameters.mediaCacheDirectorySandboxExtensionHandle);
> +    }

Two things: 
  - I think it would be better to do this in the WebProcess, this process
should just use the path provided.
  - This shouldn't be necessary at all, please file a bug about the media
framework behavior.