[webkit-reviews] review granted: [Bug 207109] Create a new ImageBuffer type for drawing on a DisplayList : [Attachment 391298] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 17:41:50 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 207109: Create a new ImageBuffer type for drawing on a DisplayList
https://bugs.webkit.org/show_bug.cgi?id=207109

Attachment 391298: Patch

https://bugs.webkit.org/attachment.cgi?id=391298&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391298
  --> https://bugs.webkit.org/attachment.cgi?id=391298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391298&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:845
> +    if (buffer() && buffer()->drawingContext() &&
buffer()->drawingContext()->replayedDisplayList())
> +	   return
buffer()->drawingContext()->replayedDisplayList()->asText(flags);

Can we if (!buffer()) return and use a buffer ref for the rest of the function?

> Source/WebCore/platform/graphics/displaylists/DisplayListDrawingContext.h:28
> +#include "AffineTransform.h"

Not needed?


More information about the webkit-reviews mailing list