[webkit-reviews] review granted: [Bug 207975] Crash in Page::updateRendering when document has no domWindow : [Attachment 391223] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 11:49:16 PST 2020


Ryosuke Niwa <rniwa at webkit.org> has granted Sunny He <sunny_he at apple.com>'s
request for review:
Bug 207975: Crash in Page::updateRendering when document has no domWindow
https://bugs.webkit.org/show_bug.cgi?id=207975

Attachment 391223: Patch

https://bugs.webkit.org/attachment.cgi?id=391223&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 391223
  --> https://bugs.webkit.org/attachment.cgi?id=391223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review

> Source/WebCore/page/Page.cpp:1334
> +	   if (document.domWindow()) {

Can we use an early return instead?


More information about the webkit-reviews mailing list