[webkit-reviews] review granted: [Bug 207944] (r256583) [ iOS ] http/tests/resourceLoadStatistics/prevalent-domains-per-page-database.html is a flaky timeout : [Attachment 391289] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 207944: (r256583) [ iOS ]
http/tests/resourceLoadStatistics/prevalent-domains-per-page-database.html is a
flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207944

Attachment 391289: Patch

https://bugs.webkit.org/attachment.cgi?id=391289&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 391289
  --> https://bugs.webkit.org/attachment.cgi?id=391289
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391289&action=review

r=ews

>
LayoutTests/http/tests/resourceLoadStatistics/prevalent-domains-per-page-databa
se.html:20
> +		   if (arrayOfDomains.length == 0) {
> +		       askForPrevalentResources();
> +		       return;

This is a tight loop, which is unfriendly to other tests running in parallel.
Maybe do it on a 100 ms timer?

>
LayoutTests/http/tests/resourceLoadStatistics/prevalent-domains-per-page-databa
se.html:25
>		       testFailed("Domain was not successfully marked
prevalent.");

Does this become dead code now, as we'll keep retrying until timeout? Maybe
it's worth to limit retries to say 20 seconds, because timeout is not a very
clear failure mode - we often assume that those are not real failures.