[webkit-reviews] review granted: [Bug 207694] [WPE] Add support for rendering sliders for range elements : [Attachment 390637] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 00:04:23 PST 2020

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 207694: [WPE] Add support for rendering sliders for range elements

Attachment 390637: Patch


--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390637
  --> https://bugs.webkit.org/attachment.cgi?id=390637

View in context: https://bugs.webkit.org/attachment.cgi?id=390637&action=review

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:368
> +    if (part != SliderThumbHorizontalPart && part !=

Wouldn't it be enought here to use an assertion instead of a conditional
statement? e.g.

  ASSERT(part == SliderThumbHorizontalPart || part == SliderThumbVerticalPart)

More information about the webkit-reviews mailing list