[webkit-reviews] review granted: [Bug 207950] Add support for AudioSession handling in GPUProcess for capture : [Attachment 391207] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 16:00:52 PST 2020


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 207950: Add support for AudioSession handling in GPUProcess for capture
https://bugs.webkit.org/show_bug.cgi?id=207950

Attachment 391207: Patch

https://bugs.webkit.org/attachment.cgi?id=391207&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 391207
  --> https://bugs.webkit.org/attachment.cgi?id=391207
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391207&action=review

> Source/WebCore/ChangeLog:17
> +	   This includes BaseAudioSharedUnit, for which we add a
audioUnitWillStart callback so that we compute the right AudioSession category
before starting the capture.

Nit: please wrap this line, it is quite long.


More information about the webkit-reviews mailing list