[webkit-reviews] review granted: [Bug 207937] [LFC][Floats] FloatingContext::constraints should be able to handle empty candidate ranges (points) : [Attachment 391165] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 207937: [LFC][Floats] FloatingContext::constraints should be able to handle
empty candidate ranges (points)
https://bugs.webkit.org/show_bug.cgi?id=207937

Attachment 391165: Patch

https://bugs.webkit.org/attachment.cgi?id=391165&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 391165
  --> https://bugs.webkit.org/attachment.cgi?id=391165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391165&action=review

> Source/WebCore/layout/floats/FloatingContext.cpp:308
> +		   return floatBoxRect.top() <= adjustedCandidateTop &&
floatBoxRect.bottom() > adjustedCandidateTop;
> +	       return !(floatBoxRect.top() >= adjustedCandidateBottom ||
floatBoxRect.bottom() <= adjustedCandidateTop);

The difference between these would be clearer if the logic was the same way
round (that is no !)