[webkit-reviews] review granted: [Bug 200764] Main implementation for lazy image loading : [Attachment 391043] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 01:08:02 PST 2020


Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 200764: Main implementation for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=200764

Attachment 391043: Patch

https://bugs.webkit.org/attachment.cgi?id=391043&action=review




--- Comment #136 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 391043
  --> https://bugs.webkit.org/attachment.cgi?id=391043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391043&action=review

>>>
LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the
-img-element/original-base-url-applied-expected.txt:4
>>> +FAIL Test that when deferred img is loaded, it uses the base URL computed
at parse time. assert_unreached: The image load should not fail, trying to load
with invalid base URL. Reached unreachable code
>> 
>> Is this new failure expected?
> 
> Yes, I will put up a patch for this soon.

Can you please add a comment in the changelog about the new failures and link
to the bug?


More information about the webkit-reviews mailing list