[webkit-reviews] review granted: [Bug 151030] ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer : [Attachment 391128] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jack <shihchieh_lee at apple.com>'s
request for review:
Bug 151030: ASSERTION FAILED:
roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in
WebCore::RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=151030

Attachment 391128: Patch

https://bugs.webkit.org/attachment.cgi?id=391128&action=review




--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 391128
  --> https://bugs.webkit.org/attachment.cgi?id=391128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391128&action=review

Looks OK. I’m frustrated that we need the data member and can’t just check
m_accumulatedOffset.mightBeSaturated(), but I assume we do need it.

> Source/WebCore/rendering/RenderGeometryMap.cpp:112
> +	   ASSERT_IMPLIES(!m_accumulatedOffsetSaturated,
roundedIntPoint(LayoutPoint(rendererMappedResult)) == result);

I think just adding the expression "m_accumulatedOffsetSaturated &&" to the
assertion would be clearer than this use of ASSERT_IMPLIES. Maybe I’m biased,
because I never heard of ASSERT_IMPLIES before today.

> Source/WebCore/rendering/RenderGeometryMap.h:134
> +    bool m_accumulatedOffsetSaturated { false };

m_accumulatedOffsetMightBeSaturated