[webkit-reviews] review requested: [Bug 197684] [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData : [Attachment 391124] patch

[bugzilla-daemon at webkit.org]

Christopher Reid <chris.reid at sony.com> has asked  for review:
Bug 197684: [Win] Implement NetworkCache::Data by using
FileSystem::MappedFileData
https://bugs.webkit.org/show_bug.cgi?id=197684

Attachment 391124: patch

https://bugs.webkit.org/attachment.cgi?id=391124&action=review




--- Comment #29 from Christopher Reid <chris.reid at sony.com> ---
Created attachment 391124

  --> https://bugs.webkit.org/attachment.cgi?id=391124&action=review

patch

I ended up re-adding FileOpenMode::ReadWrite since mmap was failing on
FileSystemPOSIX when the file was created with O_WRONLY. That caused the memory
regression in Mac.

I also wanted to check if O_EXCL is needed on this NetworkCacheData mapped file
before re-landing. I didn't carry it over to FileSystem::openFile
implementations since I don't think most openFile calls using ReadWrite will
want to always create a file. Also the parent directory for the caches are
created with S_IRWXU access.

If O_EXCL is needed it might make sense then to have something like a
FileSystem::createFile call that fails if the file already exists.