[webkit-reviews] review granted: [Bug 207875] Crash when Node::normalize() triggers mutation event that modifies child order : [Attachment 391101] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sunny He <sunny_he at apple.com>'s
request for review:
Bug 207875: Crash when Node::normalize() triggers mutation event that modifies
child order
https://bugs.webkit.org/show_bug.cgi?id=207875

Attachment 391101: Patch

https://bugs.webkit.org/attachment.cgi?id=391101&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 391101
  --> https://bugs.webkit.org/attachment.cgi?id=391101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391101&action=review

> Source/WebCore/dom/Node.cpp:674
> +	       // Update start/end for any affected Ranges

I don’t think this comment is necessary since the code says that.
If anything, we should explain why we need call this before appendData instead.

> LayoutTests/ChangeLog:17
> +	   * fast/dom/Node/normalize_mutation_event.html: Added.

Please use - instead of _ in file names