[webkit-reviews] review granted: [Bug 207777] Set User-Agent in preconnect requests : [Attachment 391091] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ben Nham <nham at apple.com>'s request
for review:
Bug 207777: Set User-Agent in preconnect requests
https://bugs.webkit.org/show_bug.cgi?id=207777

Attachment 391091: Patch

https://bugs.webkit.org/attachment.cgi?id=391091&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 391091
  --> https://bugs.webkit.org/attachment.cgi?id=391091
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391091&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1307
> +    if (!url.isValid() || !url.protocolIsInHTTPFamily() ||
SecurityOrigin::isLocalHostOrLoopbackIPAddress(url.host()))

Why do we need this check here? You're already doing them at the call site.

> Source/WebKit/UIProcess/WebPageProxy.cpp:4236
> +	   if (!networkProcess->canSendMessage())

Should not be needed.